Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reset-password)!: move the overridden components inside auth container #868

Open
wants to merge 3 commits into
base: 0.49
Choose a base branch
from

Conversation

AmanAgarwal041
Copy link

@AmanAgarwal041 AmanAgarwal041 commented Dec 11, 2024

BREAKING CHANGE: Earlier the overridden components were rendered outside the auth container, that will be moved inside the auth container.

Summary of change

Before

Screenshot 2024-12-10 at 12 45 29 AM

After

Screenshot 2024-12-10 at 12 45 05 AM

This PR updates the overridden components to be wrapped inside the

<div data-supertokens="container resetPasswordEmailForm">
  <div data-supertokens="row">
  </div>
</div>

which was earlier being rendered outside the above wrapper containers

Related issues

Fixes #786

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Remaining TODOs for this PR

…ainer

BREAKING CHANGE: Earlier the overridden components were rendered outside the auth container, that will be moved inside the auth container.
@porcellus porcellus changed the base branch from master to 0.49 December 13, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriding password reset component results in the logo outside the container
2 participants